[OpenWisp] Declared hostname required #18

netjsonconfig/backends/openwisp/openwisp.py

@@ -6,10 +6,12 @@
 from io import BytesIO
 
 from ..openwrt.openwrt import OpenWrt
+from .schema import schema
 
 
 class OpenWisp(OpenWrt):
     """ OpenWisp Backend """
+    schema = schema
 
     def generate(self, name='openwrt-config'):
         """

netjsonconfig/backends/openwisp/schema.py

@@ -0,0 +1,14 @@
+"""
+OpenWisp specific JSON-Schema definition
+(extends OpenWrt JSON-Schema)
+"""
+from ..openwrt.schema import schema as openwrt_schema
+from ...utils import merge_config
+
+schema = merge_config(openwrt_schema, {
+    "properties": {
+        "general": {
+            "required": ["hostname"]
+        }
+    }
+})

tests/openwisp/test_backend.py

@@ -3,6 +3,7 @@
 import tarfile
 
 from netjsonconfig import OpenWisp
+from netjsonconfig.exceptions import ValidationError
 from netjsonconfig.utils import _TabsMixin
 
 
@@ -31,3 +32,12 @@ def test_uci(self):
         # close and delete tar.gz file
         tar.close()
         os.remove('openwrt-config.tar.gz')
+
+    def test_hostname_required(self):
+        o = OpenWisp({
+            "general": {
+                "timezone": "Coordinated Universal Time"
+            }
+        })
+        with self.assertRaises(ValidationError):
+            o.validate()