Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(floatbar): [floatbar] Adapt to dark themes #3045

Merged
merged 6 commits into from
Mar 7, 2025
Merged

Conversation

Youyou-smiles
Copy link
Collaborator

@Youyou-smiles Youyou-smiles commented Mar 5, 2025

feat(floatbar): [floatbar] Adapt to dark themes

Summary by CodeRabbit

  • Style

    • Refreshed the floatbar component’s appearance with updated background (gray) and hover (dark gray) colors for a more modern look.
    • Improved formatting of CSS background-image properties in the virtual scroll box for better readability.
  • Refactor

    • Enhanced naming conventions for CSS variables related to the floatbar component, improving clarity and consistency in styling.

Copy link

coderabbitai bot commented Mar 5, 2025

Walkthrough

This PR updates the CSS styling and test expectations for the floatbar component across several Vue and Less files. Background colors for the .custom class and its child list items have been adjusted, and corresponding test expectations have been updated. Additionally, the CSS variable names in the theme files have been streamlined by removing redundant prefixes. No changes were made to exported entities.

Changes

File(s) Change Summary
examples/…/custom-style-composition-api.vue, examples/…/custom-style.vue Updated background color for .custom (from #dbdbdb to gray) and hover state for list items (from #fff to darkgray).
examples/…/custom-style.spec.ts Modified expected CSS property values in tests: floatbar background from rgb(219, 219, 219) to rgb(128, 128, 128) and item background from rgb(255, 255, 255) to rgb(169, 169, 169).
packages/…/floatbar/index.less, packages/…/floatbar/vars.less Renamed and updated CSS variables for border radius, background color, font-size, margin, and text colors to simplify naming conventions.
examples/…/virtual-scroll-box/table-composition-api.vue, examples/…/virtual-scroll-box/table.vue Reformatted background-image properties to remove line breaks for improved readability without changing gradient definitions.
packages/…/milestone/index.ts Minor formatting adjustment in getMileIcon function, removing space before colon in color property assignment.

Possibly related PRs

  • feat(floatbar): [floatbar] Adapt ro SMB themes #1905: The changes in the main PR, which modify the CSS styles for the .custom class, are related to the changes in the retrieved PR that also involve modifications to the .custom class, specifically altering its width, indicating a direct connection at the code level.
  • feat(floatbar): [floatbar] Adapt to dark themes #3012: The changes in the main PR, which modify the CSS styles for the .custom class and its child list items, are related to the changes in the retrieved PR that also involve updates to CSS variables and properties for the floatbar component, specifically regarding background colors and styling consistency.
  • fix(site): official website adapts to the dark mode. #2956: The changes in the main PR, which involve modifications to the CSS styles for the .custom class and its child list items, are related to the adjustments made in the retrieved PR that also focus on CSS modifications for dark mode, specifically in how styles are applied to various elements. Both PRs involve updates to CSS properties that affect the visual presentation of components.

Suggested reviewers

  • zzcr

I'm a rabbit with a code-loving hop,
Tweaking colors and styles nonstop.
The floatbar now shines in a brand new light,
With variables renamed and tests just right.
I nibble on code with a joyful heart,
Celebrating these changes—let the magic start!
🐰✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

examples/sites/demos/pc/app/virtual-scroll-box/table-composition-api.vue

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

examples/sites/demos/pc/app/virtual-scroll-box/table.vue

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

packages/design/saas/src/milestone/index.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1f056b3 and c075d0a.

📒 Files selected for processing (3)
  • examples/sites/demos/pc/app/virtual-scroll-box/table-composition-api.vue (4 hunks)
  • examples/sites/demos/pc/app/virtual-scroll-box/table.vue (4 hunks)
  • packages/design/saas/src/milestone/index.ts (1 hunks)
✅ Files skipped from review due to trivial changes (3)
  • packages/design/saas/src/milestone/index.ts
  • examples/sites/demos/pc/app/virtual-scroll-box/table-composition-api.vue
  • examples/sites/demos/pc/app/virtual-scroll-box/table.vue
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: PR E2E Test (pnpm test:e2e3)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the enhancement New feature or request (功能增强) label Mar 5, 2025
Copy link

Walkthrough

This pull request adapts the floatbar component to support dark themes by updating background colors and CSS variables. It modifies the styles in various Vue and LESS files to ensure compatibility with dark mode, enhancing the visual consistency of the floatbar across different themes.

Changes

Files Summary
custom-style-composition-api.vue, custom-style.vue Updated background colors to gray and darkgray for dark theme adaptation.
custom-style.spec.ts Adjusted test expectations for new background colors in dark theme.
index.less Changed CSS variables to support dark theme, including background and text colors.
vars.less Updated LESS variables to reflect new color schemes for dark theme support.

MomoPoppy
MomoPoppy previously approved these changes Mar 6, 2025
@zzcr zzcr merged commit cd468ac into dev Mar 7, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request (功能增强)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants