fix(grid): [grid] fix drop-config trigger don't work

[gimmyhehe]

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• New Features
  • Enhanced drag-and-drop functionality with a new customizable trigger property for drag handles.
• Version Updates
  • Updated the package version of @opentiny/vue-grid from 3.18.2 to 3.18.3.

[coderabbitai]

Walkthrough

The pull request introduces an update to the @opentiny/vue-grid package version from 3.18.2 to 3.18.3 in the package.json file. Additionally, it modifies the rowDrop method in methods.ts by adding a new property, trigger, to the dropConfig object. This addition allows for customization of the drag handle, enhancing the flexibility of the drag-and-drop functionality.

Changes

File Path	Change Summary
packages/vue/src/grid/package.json	Version updated from 3.18.2 to 3.18.3.
packages/vue/src/grid/src/dragger/src/methods.ts	Added trigger property to dropConfig in the rowDrop method, allowing for customizable drag handles.

Poem

In the meadow where we play,
A new version hops our way!
With a trigger for the drag,
Flexibility, oh what a brag!
Tiny grids now dance with glee,
As we code beneath the tree! 🐇✨

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2e0e14b and 161e534.

Files selected for processing (2)

• packages/vue/src/grid/package.json (1 hunks)
• packages/vue/src/grid/src/dragger/src/methods.ts (1 hunks)

Files skipped from review due to trivial changes (1)

• packages/vue/src/grid/package.json

Additional comments not posted (1)

packages/vue/src/grid/src/dragger/src/methods.ts (1)

68-77: Improved flexibility for row drag-and-drop configuration.

The changes introduce a new trigger property in the dropConfig object, allowing for more flexible configuration of the drag handle for row drag-and-drop functionality. This improvement addresses the issue mentioned in the PR title and enhances the component's customization options.

Consider adding a comment to explain the priority of rowHandle over trigger:

 // 配置了 rowHandle === 'index'则忽略trigger
 if (rowHandle === 'index') {
+  // rowHandle takes precedence over trigger when set to 'index'
   handle = '.tiny-grid-body__row>td.col__index>.row__drop-handle'
 }

Please update the component's documentation to reflect the new trigger option in the dropConfig object. This will help users understand and utilize the new functionality.

Let's verify the impact of these changes on existing functionality:

Verification successful

Verified the changes introduce improved flexibility without impacting existing functionality.

The modifications to the rowDrop method in packages/vue/src/grid/src/dragger/src/methods.ts successfully add a trigger property, allowing for more flexible configuration of the drag handle. This enhancement maintains backward compatibility and does not adversely affect other parts of the codebase where rowDrop and dropConfig are used.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any other occurrences of rowDrop method or dropConfig usage

# Test: Search for rowDrop method usage
echo "Searching for rowDrop method usage:"
rg --type typescript "rowDrop\s*\(" -A 5

# Test: Search for dropConfig usage
echo "Searching for dropConfig usage:"
rg --type typescript "dropConfig" -A 5

Length of output: 305

---

Script:

#!/bin/bash
# Description: Check for any other occurrences of rowDrop method or dropConfig usage

# Test: Search for rowDrop method usage with corrected file type
echo "Searching for rowDrop method usage:"
rg --type ts "rowDrop\s*\(" -A 5

# Test: Search for dropConfig usage with corrected file type
echo "Searching for dropConfig usage:"
rg --type ts "dropConfig" -A 5

Length of output: 14082

---

Script:

#!/bin/bash
# Description: Alternative approach using glob patterns to search TypeScript files

# Test: Search for rowDrop method usage using glob
echo "Searching for rowDrop method usage:"
rg "rowDrop\s*\(" --glob "*.ts" -A 5

# Test: Search for dropConfig usage using glob
echo "Searching for dropConfig usage:"
rg "dropConfig" --glob "*.ts" -A 5

Length of output: 10606

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.