Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unocss deprecation warning #1859

Closed
wants to merge 1 commit into from

Conversation

gweesin
Copy link
Contributor

@gweesin gweesin commented Aug 7, 2024

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

caused by #1858, the e2e ci test error.

https://github.com/opentiny/tiny-vue/actions/runs/10284935002/job/28462050376?pr=1858

Issue Number: #1858

What is the new behavior?

should not tip deprecation warning

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • New Features

    • Integrated UnoCSS Vite plugin to enhance CSS utilities development experience.
    • Improved configuration structure for Unocss using defineConfig for better organization and extensibility.
  • Bug Fixes

    • Resolved potential configuration issues with clearer structure in the Unocss setup.

Copy link

coderabbitai bot commented Aug 7, 2024

Walkthrough

The changes introduce a new dependency, @unocss/vite, to enhance the project with Vite integration for UnoCSS. Additionally, the configuration file for UnoCSS has been refactored to use the defineConfig function, allowing for better structure and potential future enhancements while maintaining existing functionality for file type inclusion.

Changes

Files Change Summary
examples/sites/package.json Added @unocss/vite as a dependency with version ^0.61.9.
examples/sites/uno.config.js Refactored configuration to use defineConfig, introducing a content property for file type inclusion.

Poem

In the meadow where styles grow,
A new friend hops, a CSS glow!
With Vite now by our side,
Configs dance, we take pride.
Hooray for changes, bright and spry,
A rabbit's joy—oh, how we fly! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Aug 7, 2024

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4dbc4d3 and 31eab89.

Files selected for processing (2)
  • examples/sites/package.json (1 hunks)
  • examples/sites/uno.config.js (2 hunks)
Additional comments not posted (4)
examples/sites/uno.config.js (3)

3-3: Import statement is correct.

The defineConfig function from @unocss/vite is correctly imported.


5-5: Export statement is correct.

The configuration is now encapsulated using defineConfig from @unocss/vite, which is a good practice.


6-10: Content property is correctly structured.

The content property contains a pipeline object with the same array of file types for inclusion as before, ensuring the scanning functionality remains unchanged.

examples/sites/package.json (1)

57-57: New dependency is correctly added.

The @unocss/vite dependency with version ^0.61.9 is correctly added to the devDependencies section.

@@ -54,6 +54,7 @@
"@types/markdown-it": "^12.2.3",
"@types/node": "^17.0.45",
"@unocss/preset-icons": "^0.61.9",
"@unocss/vite": "^0.61.9",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

您好,感谢你的贡献,这块因为内部可信版本没有达到0.61.x这个版本,所以暂时还升级不了,因为官网是需要在内部发布的

@zzcr zzcr closed this Sep 2, 2024
@gweesin gweesin deleted the fix/unocss-deprecated branch March 10, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants