-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unocss deprecation warning #1859
Conversation
WalkthroughThe changes introduce a new dependency, Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- examples/sites/package.json (1 hunks)
- examples/sites/uno.config.js (2 hunks)
Additional comments not posted (4)
examples/sites/uno.config.js (3)
3-3
: Import statement is correct.The
defineConfig
function from@unocss/vite
is correctly imported.
5-5
: Export statement is correct.The configuration is now encapsulated using
defineConfig
from@unocss/vite
, which is a good practice.
6-10
: Content property is correctly structured.The content property contains a pipeline object with the same array of file types for inclusion as before, ensuring the scanning functionality remains unchanged.
examples/sites/package.json (1)
57-57
: New dependency is correctly added.The
@unocss/vite
dependency with version^0.61.9
is correctly added to the devDependencies section.
@@ -54,6 +54,7 @@ | |||
"@types/markdown-it": "^12.2.3", | |||
"@types/node": "^17.0.45", | |||
"@unocss/preset-icons": "^0.61.9", | |||
"@unocss/vite": "^0.61.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
您好,感谢你的贡献,这块因为内部可信版本没有达到0.61.x这个版本,所以暂时还升级不了,因为官网是需要在内部发布的
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
caused by #1858, the e2e ci test error.
https://github.com/opentiny/tiny-vue/actions/runs/10284935002/job/28462050376?pr=1858
Issue Number: #1858
What is the new behavior?
should not tip deprecation warning
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
defineConfig
for better organization and extensibility.Bug Fixes