OCPBUGS-56853, OPRUN-3925: [Default Catalog Consistency Test] (feat) add check to validate multi-arch support #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilamacedo86
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@camilamacedo86: This pull request references OPRUN-3793 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@camilamacedo86: This pull request references OPRUN-3793 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@camilamacedo86: This pull request references OPRUN-3793 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
camilamacedo86
changed the title
|
@camilamacedo86: An error was encountered updating to the POST state for bug OCPBUGS-56853 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details. Full error message.
No response returned: Post "https://issues.redhat.com/rest/api/2/issue/17017443/transitions": POST https://issues.redhat.com/rest/api/2/issue/17017443/transitions giving up after 5 attempt(s)
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
camilamacedo86
force-pushed
the
multiarch-catalog
branch
from
7992e79 to
0b1057a
Compare
openshift-ci-robot
added
jira/severity-important
|
@camilamacedo86: This pull request references Jira Issue OCPBUGS-56853, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…k to validate multi-arch support
camilamacedo86
force-pushed
the
multiarch-catalog
branch
from
0b1057a to
34a7a6b
Compare
camilamacedo86
changed the title
|
@camilamacedo86: This pull request references Jira Issue OCPBUGS-56853, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. This pull request references OPRUN-3925 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
c/c @joelanford |
perdasilva
reviewed
May 30, 2025
| @@ -112,6 +114,67 @@ func ImageHasLabels(expectedLabels map[string]string) ImageCheck { | |||
| } | |||
| } | |||
|
|
|||
| // RequiredPlatforms is a list of platforms that are required for the image to be considered valid. | |||
| var RequiredPlatforms = []specsgov1.Platform{ | |||
There was a problem hiding this comment.
I wonder if we should restrict it to this set to get noisy if a new architecture/OS is added...?
There was a problem hiding this comment.
I just don't see anyone remembering to come and update this test if a new arch is added XD
There was a problem hiding this comment.
I think we must ensure those
If any pipeline builds more than that is probably fine 👍
But unlikely . Not sure .. If we should care .. I do not have a really strong opinion over that
|
/lgtm - just left an open question |
|
@camilamacedo86: This pull request references Jira Issue OCPBUGS-56853, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. This pull request references OPRUN-3925 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
thetechnick
approved these changes
Jun 2, 2025
|
@tmshort @rashmigottipati @anik120 Could you give a hand on this one so we can move forward? |
1 similar comment
|
@tmshort @rashmigottipati @anik120 Could you give a hand on this one so we can move forward? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, perdasilva, thetechnick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@camilamacedo86: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@camilamacedo86: Jira Issue OCPBUGS-56853: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-56853 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@camilamacedo86: new pull request created: #370 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test to verify multiarch support
/cherrypick release-4.19 release-4.18 release-4.17
PS.: tested executed against old versions and all worked fine.
Example of failures
We added darwin/arm64 as required to emulate and validate the check, see:
PS. A follow-up JIRA was created for us to check if we could validate the content as well.
However, it needs to be explanatory, for now we will check just the image
More info: https://issues.redhat.com/browse/OPRUN-3942