OSSM-9037 Show oc label command in Performing RevisionBased update procedure #90146
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/XS
|
🤖 Wed Mar 12 15:30:07 - Prow CI generated the docs preview: |
|
@gwynnemonahan: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| + | ||
| [source,terminal] | ||
| ---- | ||
| $ oc label namespace <namespace_name> istio.io/rev=<new_revision_name> |
There was a problem hiding this comment.
Since the namespace would have already had the label pointing to the previous revision, we should be using overwrite flag. i.e., the command should be
Suggested change
| $ oc label namespace <namespace_name> istio.io/rev=<new_revision_name> | |
| $ oc label namespace <namespace_name> istio.io/rev=<new_revision_name> --overwrite |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSSM 3.0
OSSM-9037 Show oc label command in Performing RevisionBased update procedure
Merge PR to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-main
And cherry picked to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-3.0
Version(s):
OSSM 3.0
Issue:
https://issues.redhat.com/browse/OSSM-9037
Link to docs preview:
https://90146--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/update/ossm-updating-openshift-service-mesh.html#performing-revisionbased-update_ossm-attach-workloads-to-control-plane-revisionbased
QE review:
Additional information: