OCM-12971 | 'ocm gcp update wif-config' remediates all wif-config misconfigurations #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckandag
reviewed
Dec 12, 2024
ckandag
reviewed
Dec 12, 2024
ckandag
reviewed
Dec 12, 2024
ckandag
reviewed
Dec 12, 2024
ckandag
reviewed
Dec 12, 2024
renan-campos
force-pushed
the
OCM-12971
branch
from
dc439d0 to
2ff3278
Compare
ckandag
approved these changes
Dec 12, 2024
JakobGray
approved these changes
Dec 12, 2024
ckandag
added a commit
that referenced
this pull request
Feb 27, 2025
-3a8ef75 OCM-12971 | 'ocm gcp update wif-config' remediates all wif-config misconfigurations (#696) -d4deb29 Add 'version' flag to wif-config create and update commands (#698) -f079176 updated help message for wif verification errors -1fb1d56 Refactored GCP client operations to log user messages and optimized resource updation (#700) -dd04c33 Update Konflux references (#697) -c84225e OCM-11995 | feat : Add GCP KMS custom encryption support (#701) -7ac7051 added 'availability-zone' argument to machine pool creation (#703) -56ca538 updates to konflux_build_pipeline (#704) -b37893c listing wif-configs shows supported versions (#706) -7087572 Update Konflux references (#702) -7aac46f Update Konflux references (#707) -2045f98 Update github.com/pkg/browser digest to 5ac0b6a (#708) -0b6615a Update module github.com/golang-jwt/jwt/v4 to v4.5.1 (#709) -1cf3d22 Update module github.com/openshift-online/ocm-sdk-go to v0.1.459 (#711) -579f8de Update module github.com/golang/glog to v1.2.4 (#710) -c5c95d5 n-3 vesion supportfor wif-update (#713)
ckandag
added a commit
that referenced
this pull request
Feb 27, 2025
-3a8ef75 OCM-12971 | 'ocm gcp update wif-config' remediates all wif-config misconfigurations (#696) -d4deb29 Add 'version' flag to wif-config create and update commands (#698) -f079176 updated help message for wif verification errors -1fb1d56 Refactored GCP client operations to log user messages and optimized resource updation (#700) -dd04c33 Update Konflux references (#697) -c84225e OCM-11995 | feat : Add GCP KMS custom encryption support (#701) -7ac7051 added 'availability-zone' argument to machine pool creation (#703) -56ca538 updates to konflux_build_pipeline (#704) -b37893c listing wif-configs shows supported versions (#706) -7087572 Update Konflux references (#702) -7aac46f Update Konflux references (#707) -2045f98 Update github.com/pkg/browser digest to 5ac0b6a (#708) -0b6615a Update module github.com/golang-jwt/jwt/v4 to v4.5.1 (#709) -1cf3d22 Update module github.com/openshift-online/ocm-sdk-go to v0.1.459 (#711) -579f8de Update module github.com/golang/glog to v1.2.4 (#710) -c5c95d5 n-3 vesion supportfor wif-update (#713)
Merged
renan-campos
pushed a commit
that referenced
this pull request
Feb 27, 2025
-3a8ef75 OCM-12971 | 'ocm gcp update wif-config' remediates all wif-config misconfigurations (#696) -d4deb29 Add 'version' flag to wif-config create and update commands (#698) -f079176 updated help message for wif verification errors -1fb1d56 Refactored GCP client operations to log user messages and optimized resource updation (#700) -dd04c33 Update Konflux references (#697) -c84225e OCM-11995 | feat : Add GCP KMS custom encryption support (#701) -7ac7051 added 'availability-zone' argument to machine pool creation (#703) -56ca538 updates to konflux_build_pipeline (#704) -b37893c listing wif-configs shows supported versions (#706) -7087572 Update Konflux references (#702) -7aac46f Update Konflux references (#707) -2045f98 Update github.com/pkg/browser digest to 5ac0b6a (#708) -0b6615a Update module github.com/golang-jwt/jwt/v4 to v4.5.1 (#709) -1cf3d22 Update module github.com/openshift-online/ocm-sdk-go to v0.1.459 (#711) -579f8de Update module github.com/golang/glog to v1.2.4 (#710) -c5c95d5 n-3 vesion supportfor wif-update (#713)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The following new behavior was added to the functionality of the command used to update resources associated with wif-configs:
Testing
The resources of a test wif-config resource was manually modified into the states described above. Running
ocm gcp verify wif-configconfirmed that the error related to the misconfiguration was detected. After runningocm gcp update wif-config, verification succeeds. Manual inspection of GCP resources confirms that their configuration was corrected through calling the update command.