Add macos package builder #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
added
the
Infrastructure
Codecov Report
@@ Coverage Diff @@
## main #40 +/- ##
=======================================
Coverage 67.26% 67.26%
=======================================
Files 31 31
Lines 1848 1848
=======================================
Hits 1243 1243
Misses 499 499
Partials 106 106
Flags with carried forward coverage won't be shown. Click here to find out more. |
jmazanec15
reviewed
Dec 6, 2021
|
|
||
| deleteInstallationDirectory() { | ||
| log_info "Cleaning $TARGET_DIRECTORY directory." | ||
| rm -rf $TARGET_DIRECTORY |
There was a problem hiding this comment.
Why not make target dir an argument, as is done in previous functions?
macos-pkg-builder/build-macos.sh
Outdated
| copyBuildDirectory() { | ||
| sed -i '' -e 's/__VERSION__/'${VERSION}'/g' ${TARGET_DIRECTORY}/darwin/scripts/postinstall | ||
| sed -i '' -e 's/__PRODUCT__/'${PRODUCT}'/g' ${TARGET_DIRECTORY}/darwin/scripts/postinstall | ||
| chmod -R 755 ${TARGET_DIRECTORY}/darwin/scripts/postinstall |
There was a problem hiding this comment.
Dont we already do this in copyDarwinDirectory?
VijayanB
force-pushed
the
macos-pkg-builder
branch
from
81452e3 to
07b6203
Compare
Added script which will generate macos pkg from opensearch-cli binary. To generate pkg, copy opensearch-cli binary into application folder. Execute script "build-macos.sh" by following usuage instructions. pkg will be generated inside target/pkg directory. Signed-off-by: Vijayan Balasubramanian <[email protected]>
VijayanB
force-pushed
the
macos-pkg-builder
branch
from
07b6203 to
2013b8f
Compare
jmazanec15
approved these changes
Dec 8, 2021
naveentatikonda
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added script which will generate macos pkg from opensearch-cli
binary. To generate pkg, copy opensearch-cli binary into
application folder. Execute script "build-macos.sh" by following
usuage instructions.
pkg will be generated inside target/pkg directory.
Signed-off-by: Vijayan Balasubramanian [email protected]
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.