Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update files from basic templates #24

Merged
merged 3 commits into from
Jun 28, 2021

Conversation

VijayanB
Copy link
Member

@VijayanB VijayanB commented Jun 28, 2021

Description

  • Add link check.
  • Update files based on template.
  • Enable Integration tests.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has documentation added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

VijayanB added 2 commits June 28, 2021 14:17
Exclude fake endpoints created for README.

Signed-off-by: Vijayan Balasubramanian <[email protected]>
Copied and updated to standard template.

Signed-off-by: Vijayan Balasubramanian <[email protected]>
@VijayanB VijayanB requested review from jmazanec15 and vamshin June 28, 2021 21:19
Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

Since docker image is based on opensearch, enable
integration test back.

Signed-off-by: Vijayan Balasubramanian <[email protected]>
@VijayanB VijayanB merged commit 0e3b50a into opensearch-project:main Jun 28, 2021
@VijayanB VijayanB self-assigned this Jun 28, 2021
@VijayanB VijayanB added the Documentation A change to update existing documentations such as README, instruction docs, etc. label Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation A change to update existing documentations such as README, instruction docs, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants