-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pull-based Ingestion] Add support for dynamically updating ingestion error handling strategy #17565
base: main
Are you sure you want to change the base?
[Pull-based Ingestion] Add support for dynamically updating ingestion error handling strategy #17565
Conversation
❌ Gradle check result for 92b576e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
92b576e
to
9f94093
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17565 +/- ##
============================================
- Coverage 72.43% 72.41% -0.02%
- Complexity 65694 65719 +25
============================================
Files 5311 5311
Lines 304937 304962 +25
Branches 44226 44227 +1
============================================
- Hits 220872 220842 -30
- Misses 65912 66058 +146
+ Partials 18153 18062 -91 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Would it be better to keep retrying indefinitely at some fixed rate? It can be hard to determine if errors are transient or not, and in this case if you enter the paused state because of a transient failure you'll just be stuck until something intervenes, right? |
server/src/main/java/org/opensearch/indices/pollingingest/DefaultStreamPoller.java
Outdated
Show resolved
Hide resolved
33fee6a
to
e6e34ed
Compare
Good point, as discussed today, updated to indefinitely retry and skip only after user switches to a DROP policy. |
❌ Gradle check result for e6e34ed: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Varun Bharadwaj <[email protected]>
e6e34ed
to
5c0788c
Compare
❌ Gradle check result for 5c0788c: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Varun Bharadwaj <[email protected]>
5c0788c
to
589c235
Compare
Description
This PR forms the base on which subsequent PRs will build on for adding pause/resume APIs.
Related Issues
Resolves part of #17442. Subsequent PRs will add pause/resume APIs.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.