Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Temporary Reschedule for UnitedDeployment Adaptive Strategy #1941

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AiRanthem
Copy link
Member

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 67.39130% with 105 lines in your changes missing coverage. Please review.

Project coverage is 42.85%. Comparing base (29258d3) to head (80633f2).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...er/uniteddeployment/uniteddeployment_controller.go 75.18% 28 Missing and 5 partials ⚠️
...roller/uniteddeployment/uniteddeployment_update.go 46.55% 29 Missing and 2 partials ⚠️
pkg/controller/util/workload_utils.go 28.57% 20 Missing ⚠️
pkg/controller/uniteddeployment/subset_control.go 0.00% 11 Missing ⚠️
...deployment/adapter/advanced_statefulset_adapter.go 0.00% 2 Missing ⚠️
...oller/uniteddeployment/adapter/cloneset_adapter.go 0.00% 2 Missing ⚠️
...ler/uniteddeployment/adapter/deployment_adapter.go 0.00% 2 Missing ⚠️
...er/uniteddeployment/adapter/statefulset_adapter.go 0.00% 2 Missing ⚠️
pkg/controller/uniteddeployment/revision.go 50.00% 1 Missing ⚠️
...teddeployment/uniteddeployment_controller_utils.go 97.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1941      +/-   ##
==========================================
+ Coverage   42.57%   42.85%   +0.27%     
==========================================
  Files         313      315       +2     
  Lines       31364    31594     +230     
==========================================
+ Hits        13354    13539     +185     
- Misses      16642    16680      +38     
- Partials     1368     1375       +7     
Flag Coverage Δ
unittests 42.85% <67.39%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…/ finish scaling and temporary reschedule

Signed-off-by: AiRanthem <[email protected]>
…/ 1. rename "staging" to "reserved"; 2. add upgrade process

Signed-off-by: AiRanthem <[email protected]>
@AiRanthem AiRanthem force-pushed the feature/ud-temp-reschedule-250221 branch from c625f04 to 80633f2 Compare March 10, 2025 09:35
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fei-guo for approval by writing /assign @fei-guo in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants