Fix critical tracing module issues and improve reliability #957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses critical gaps and improves the robustness of the tracing module. Key changes include: Fixed Merge-Blocking Issues: 1. Missing Import for TraceProvider • Added from .provider import TraceProvider to ensure users can import TraceProvider directly via from agents.tracing import TraceProvider. 2. Type Hint Compatibility: • Added from __future__ import annotations to safely support modern type hints (e.g., List[TracingProcessor]) on Python <3.10. 3. Shutdown Hook Safety: • Added a check to ensure provider.shutdown() exists before registering it with atexit, preventing AttributeError for custom providers without a shutdown method. 4. Removed Unused Imports • Removed unused Optional from typing to clean up code. Improved Logging & Documentation: • Updated logging to use logging.debug for success messages (e.g., provider initialization) and logging.warning for failures, ensuring clarity in debugging. • Clarified documentation to reflect actual fallback behavior (removed references to a hypothetical NoOpTraceProvider). Future Improvements: • Thread safety for provider access (get_trace_provider/set_trace_provider) is noted as a future enhancement. A follow-up PR can wrap these in a lock if needed. Why This Matters? These changes ensure the tracing module is: • More reliable : Handles edge cases (e.g., invalid providers, missing methods). • Easier to maintain : Cleaner imports, accurate type hints, and explicit error handling. • Ready for production : Resolves all merge-blocking issues while preserving backward compatibility.
rm-openai
requested changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses critical gaps and improves the robustness of the tracing module. Key changes include:
Fixed Merge-Blocking Issues:
Missing Import for TraceProvider • Added from .provider import TraceProvider to ensure users can import TraceProvider directly via from agents.tracing import TraceProvider.
Type Hint Compatibility: • Added from future import annotations to safely support modern type hints (e.g., List[TracingProcessor]) on Python <3.10.
Shutdown Hook Safety: • Added a check to ensure provider.shutdown() exists before registering it with atexit, preventing AttributeError for custom providers without a shutdown method.
Removed Unused Imports • Removed unused Optional from typing to clean up code.
Improved Logging & Documentation:
• Updated logging to use logging.debug for success messages (e.g., provider initialization) and logging.warning for failures, ensuring clarity in debugging. • Clarified documentation to reflect actual fallback behavior (removed references to a hypothetical NoOpTraceProvider).
Future Improvements:
• Thread safety for provider access (get_trace_provider/set_trace_provider) is noted as a future enhancement. A follow-up PR can wrap these in a lock if needed.
Why This Matters?
These changes ensure the tracing module is:
• More reliable : Handles edge cases (e.g., invalid providers, missing methods). • Easier to maintain : Cleaner imports, accurate type hints, and explicit error handling. • Ready for production : Resolves all merge-blocking issues while preserving backward compatibility.