Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow mode as argument #2893

Merged
merged 2 commits into from
Jun 15, 2022
Merged

fix: allow mode as argument #2893

merged 2 commits into from
Jun 15, 2022

Conversation

younik
Copy link
Contributor

@younik younik commented Jun 14, 2022

Description

After #2706, render with Wrappers doesn't work anymore with mode as argument without keyword.
For instance, the following will throw an error:

env = gym.make("FrozenLake-v1")
env.reset()
env.render('rgb_array')

This should fix this.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@younik younik mentioned this pull request Jun 15, 2022
1 task
@pseudo-rnd-thoughts
Copy link
Contributor

LGTM

@jkterry1 jkterry1 merged commit a5afdb3 into openai:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants