Fix __del__ in VectorEnv

openai · Jun 2, 2019 · da71bd1 · da71bd1
1 parent d3bd3bb
commit da71bd1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/gym/vector/async_vector_env.py b/gym/vector/async_vector_env.py
@@ -299,7 +299,9 @@ def _raise_if_errors(self):
             raise exctype(value)
 
     def __del__(self):
-        self.close(terminate=True)
+        if not self.closed:
+            self.close(terminate=True)
+        super(AsyncVectorEnv, self).__del__()
 
 
 def _worker(index, env_fn, pipe, parent_pipe, shared_memory, error_queue):

diff --git a/gym/vector/vector_env.py b/gym/vector/vector_env.py
@@ -65,4 +65,6 @@ def close(self, **kwargs):
         self.closed = True
 
     def __del__(self):
-        self.close()
+        if not self.closed:
+            self.close()
+        super(VectorEnv, self).__del__()