Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When same stringparam is defined on both the command line and within the DC file, build breaks #589

Closed
ghost opened this issue Feb 18, 2021 · 0 comments
Labels

Comments

@ghost
Copy link

ghost commented Feb 18, 2021

Problem description

  • The DC file contains XSLTPARAM="--param show.edit.link=1".
  • We use a command that defines the same parameter again: daps -d DC-RA-Ampere-SES --force -vv html --stringparam='show.edit.link=1'

xsltproc complains about the parameter having been defined already and refuses to cooperate:

runtime error
Global parameter show.edit.link already defined
runtime error
Global parameter show.edit.link already defined
Writing /data/gits/sbp/build/RA-Ampere-SES/html/RA-Ampere-SES/index.html for article
no result for /data/gits/sbp/build/.profiled/noprofile/RA-Ampere-SES.xml
make: *** [/usr/share/daps/make/html.mk:271: /data/gits/sbp/build/RA-Ampere-SES/html/RA-Ampere-SES/index.html] Error 9

Expected behavior

The (last defined) parameter from the command line should gain precedence and overwrite the other(s). Build should succeed.

References

ghost pushed a commit to SUSE/suse-best-practices that referenced this issue Feb 19, 2021
We set the same parameter again within the Docserv2 environment and
xsltproc does not like parameters defined twice and thus fails to
build.

Reported as DAPS issue: openSUSE/daps#589

Congratulations to Meike who is our new MVP of bug-finding,
uncovering two issues in a day by adding a single parameter to DC
files. 🎉
ghost pushed a commit that referenced this issue Feb 25, 2021
ghost pushed a commit that referenced this issue Feb 25, 2021
ghost pushed a commit that referenced this issue Feb 25, 2021
@ghost ghost closed this as completed in a69814b Feb 25, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant