-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix git pull error in core contrib test #3357
base: main
Are you sure you want to change the base?
Fix git pull error in core contrib test #3357
Conversation
ff2f9e6
to
021c31b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My idea for this one would be just do a actions/checkout first. If checkout works, it means will be able to install things from that revision
We already do a checkout before hitting this error, the actions/checkout action has a retry built in which is why we do not see this error there. I couldn't see a flag for tox that would let us use the output of that checkout in runs-on: ubuntu-latest
steps:
- name: Checkout contrib repo @ SHA - ${% raw %}{{ env.CONTRIB_REPO_SHA }}{% endraw %}
uses: actions/checkout@v4
with:
repository: open-telemetry/opentelemetry-python-contrib
ref: ${% raw %}{{ env.CONTRIB_REPO_SHA }}{% endraw %}
- name: Set up Python 3.8
uses: actions/setup-python@v5
with:
python-version: "3.8"
architecture: "x64"
- name: Install tox
run: pip install tox-uv
- name: Run tests
run: tox -e {{ job_data.tox_env }} -- -ra The revision always exists (it's used for all of the other actions that run successfully and the previous checkout step) but we fail without retry when tox pulls it in |
I mean, checkout core repo at the core repo revision we want before the contrib one. We only have this problem for |
Understood - I'll update my PR so that it only adds that checkout for core_contrib tests. |
021c31b
to
677d607
Compare
677d607
to
9932189
Compare
Core contrib is intermittently failing when pulling the core repo in tox. Add gh actions/checkout for the core repo before running tox to mitigate this.
9932189
to
5764d8b
Compare
Description
Core contrib is intermittently failing when pulling the core repo in tox.
Add gh actions/checkout for the core repo before running tox to mitigate this.
As the error is transient I'm not 100% sure that this resolves it but I have not encountered it with any of the GH Actions that have been triggered.
Fixes #3352
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist: