New JWT verify/decode #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 20, 2018 13:17
Signed-off-by: Richard Kettlewell <[email protected]>
Signed-off-by: Richard Kettlewell <[email protected]>
Signed-off-by: Richard Kettlewell <[email protected]>
This implements JWT verification and decoding in a single function, supporting the exp and nbf claims automatically and permitting constraints on the algorithm and issuer to be imposed. re open-policy-agent#884 Signed-off-by: Richard Kettlewell <[email protected]>
re open-policy-agent#884 Signed-off-by: Richard Kettlewell <[email protected]>
docs/book/language-reference.md
Outdated
|
|
||
| Exactly one of ``cert`` and ``secret`` must be present. | ||
| If there are any unrecognized constraints then the token is considered invalid. | ||
|
|
There was a problem hiding this comment.
It would be helpful to add another column Required to specify which constraint members are required vs optional.
There was a problem hiding this comment.
None of them are required - the only requirement is that one of cert and secret must be present. Still, you're right, breaking out a separate column improves clarity.
|
@optnfast This looks good. Some minor comments. |
added 2 commits
September 24, 2018 11:17
re open-policy-agent#884 re open-policy-agent#967 Signed-off-by: Richard Kettlewell <[email protected]>
re open-policy-agent#884 re open-policy-agent#967 Signed-off-by: Richard Kettlewell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sequence of changes implements JWT verification and decoding in a single call. It allows verification to be constrained by key, algorithm, issuer, audience and time (i.e. the
expandnbffields).See #884 for discussion.