Improve query input support #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The construction of the global variables map passed to topdown can be re-used in a few places, so move it into topdown. The query string parsing is kept in the server package as that part is relatively simple.
These functions do not require the entire context. They only depend on the ability to resolve references to base documents to native Go values. As such, it makes sense to limit the coupling.
This change required refactoring the topdown.Query interface to return multiple document values instead of a single one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes improve support for query inputs. Most of the commits are refactoring done along the way. The core changes are in "Update topdown.Query to support non-ground globals" (6fa4848). These changes make topdown queries evaluate the globals before performing evaluation on the query itself. For each set of bindings of the globals, the query is executed. The result is a set of sets where the inner-most set contains both the query result/document value AND the bindings for variables found in the globals.
With these changes, the REST API will now return the set of sets/array of arrays if global inputs contain variables. The REST API docs have been updated to show this.