Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix command bugs in localization tasks' README #2244

Merged
merged 2 commits into from
Mar 6, 2023

Conversation

hukkai
Copy link
Collaborator

@hukkai hukkai commented Feb 21, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily got feedback.
If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduces changes that break the back-compatibility of this repo?
If so, please describe how it breaks the compatibility and how users should modify their codes to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools should be used to fix the potential lint issues.
  2. The modification should be covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation should be modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (acb79e4) 76.38% compared to head (3679c53) 76.33%.

❗ Current head 3679c53 differs from pull request most recent head 0a72f73. Consider uploading reports for the commit 0a72f73 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2244      +/-   ##
===========================================
- Coverage    76.38%   76.33%   -0.05%     
===========================================
  Files          161      157       -4     
  Lines        12607    12124     -483     
  Branches      2100     1998     -102     
===========================================
- Hits          9630     9255     -375     
+ Misses        2486     2408      -78     
+ Partials       491      461      -30     
Flag Coverage Δ
unittests 76.33% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ion/models/data_preprocessors/data_preprocessor.py 54.83% <0.00%> (-42.09%) ⬇️
mmaction/datasets/transforms/pose_transforms.py 91.40% <0.00%> (-0.77%) ⬇️
mmaction/models/backbones/resnet3d.py 90.31% <0.00%> (-0.06%) ⬇️
mmaction/models/heads/__init__.py 100.00% <0.00%> (ø)
mmaction/models/backbones/resnet.py 93.33% <0.00%> (ø)
mmaction/models/backbones/__init__.py 100.00% <0.00%> (ø)
mmaction/models/recognizers/__init__.py 100.00% <0.00%> (ø)
mmaction/datasets/transforms/__init__.py 100.00% <0.00%> (ø)
mmaction/models/backbones/resnet3d_slowonly.py 80.00% <0.00%> (ø)
mmaction/models/data_preprocessors/__init__.py 100.00% <0.00%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ly015 ly015 changed the base branch from dev-1.x to 1.x March 6, 2023 09:42
@ly015 ly015 force-pushed the fix-localization branch from f4de0b6 to 6f52e91 Compare March 6, 2023 10:08
@ly015 ly015 changed the base branch from 1.x to dev-1.x March 6, 2023 10:11
@ly015 ly015 force-pushed the fix-localization branch from 6f52e91 to 0a72f73 Compare March 6, 2023 10:12
@ly015 ly015 force-pushed the fix-localization branch from 0a72f73 to 6288921 Compare March 6, 2023 10:14
@ly015 ly015 merged commit 4e9b7ec into open-mmlab:dev-1.x Mar 6, 2023
@hukkai hukkai deleted the fix-localization branch June 20, 2023 08:43
@hukkai hukkai restored the fix-localization branch June 20, 2023 08:43
@hukkai hukkai deleted the fix-localization branch June 20, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants