Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] support gradcam #2049

Merged
merged 11 commits into from
Nov 25, 2022
Merged

[Improve] support gradcam #2049

merged 11 commits into from
Nov 25, 2022

Conversation

cir7
Copy link
Collaborator

@cir7 cir7 commented Nov 10, 2022

Motivation

[Improvement] support gradcam

@ly015 ly015 changed the title [Improvement] support gradcam [Improve] support gradcam Nov 15, 2022
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Base: 76.00% // Head: 76.86% // Increases project coverage by +0.85% 🎉

Coverage data is based on head (cb9c6a1) compared to base (040bd8b).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head cb9c6a1 differs from pull request most recent head 6913897. Consider uploading reports for the commit 6913897 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2049      +/-   ##
===========================================
+ Coverage    76.00%   76.86%   +0.85%     
===========================================
  Files          137      137              
  Lines         9924     9919       -5     
  Branches      1627     1627              
===========================================
+ Hits          7543     7624      +81     
+ Misses        2029     1944      -85     
+ Partials       352      351       -1     
Flag Coverage Δ
unittests 76.86% <100.00%> (+0.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/apis/inference.py 43.75% <ø> (ø)
mmaction/datasets/transforms/formatting.py 83.49% <ø> (ø)
mmaction/models/heads/base.py 80.00% <100.00%> (+2.09%) ⬆️
mmaction/models/recognizers/base.py 60.71% <100.00%> (-2.21%) ⬇️
mmaction/utils/gradcam_utils.py 97.72% <100.00%> (+88.53%) ⬆️
mmaction/models/heads/tpn_head.py 85.71% <0.00%> (+2.38%) ⬆️
mmaction/models/backbones/resnet2plus1d.py 100.00% <0.00%> (+4.00%) ⬆️
mmaction/models/recognizers/recognizer2d.py 59.61% <0.00%> (+9.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -1,5 +1,6 @@
# Copyright (c) OpenMMLab. All rights reserved.
import torch
import torch.nn as nn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about moving this to 'visualization/grad_cam.py'?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will reorganize visualzation tools structure in pr #2092

@ly015 ly015 merged commit 43d7ad6 into open-mmlab:dev-1.x Nov 25, 2022
ly015 pushed a commit that referenced this pull request Jan 10, 2023
@cir7 cir7 deleted the lilin/gradcam branch March 2, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants