优化judge内存使用 #326
Merged
优化judge内存使用 #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdh67899
reviewed
Dec 28, 2017
| @@ -32,6 +33,10 @@ func (this *Judge) Send(items []*model.JudgeItem, resp *model.SimpleRpcResponse) | |||
| // 把当前时间的计算放在最外层，是为了减少获取时间时的系统调用开销 | |||
| now := time.Now().Unix() | |||
| for _, item := range items { | |||
| exists := g.FilterMap.Exists(item.Metric) | |||
There was a problem hiding this comment.
👍， 一直想提交一个pr把不需要报警判断的metric丢掉(轻微强迫症)
这里会不会出现这样的问题:
如果expression里面只定义了tag判断，如each(project=falcon module=judge)，数据上报的时候在最这里会不会因为没办法找到metric把数据丢掉，造成expression报警始终不能触发?
谢谢
There was a problem hiding this comment.
expression里面不指定metric是不能生效的，所以不存在你说的问题
There was a problem hiding this comment.
expression的代码我看的不够详细，哈哈，:blush:
laiwei
approved these changes
Jan 2, 2018
Closed
|
请问， agent 收集间隔缩小到10s后 ， judge崩溃了。 judge最小收集间隔支持多少 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
优化judge使用，使内存使用率仅为之前的40分之一