fix(condo): DOMA-10565 make recurrent payments pay if receipt was partially payed #5846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recurrent payments
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we checked if receipt had any payments. If it had, that means receipt was paid and we skip it.
Now we calculate how much was paid, based on "getNewPaymentsSum()" in RegisterMultiPaymentService. If we did not manually pay enough, receipt.toPay - paidAmount should be payed. RegisterMultiPaymentService knows how to calculate that number, we just need to send receipt to it . So filtering of receipts needed just for informational errors