Refactor - Syntax: Move theme / configuration to subscription #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1613 exposed a timing issue with the server (because the syntax server starts later than it did in the prior strategy) - we'd lose the theme and configuration events because they'd be sent before initialization.
A more robust strategy, and in-line with the ultimate goal of removing the
SyntaxStoreConnectorand having it purely be pure-buffer based subscriptions, is to move the theme and configuration info into the subscription. This way, we can handle the synchronization as a detail in the subscription - the consumer just pushes the theme/configuration and the subscription handles the synchronization, which is simpler to work with and manage for the consumer, as well as solving that particular timing issue in #1613.