Skip to content
This repository was archived by the owner on Feb 4, 2025. It is now read-only.

Port rust binding from Unblob #1

Merged
merged 3 commits into from
May 4, 2023
Merged

Port rust binding from Unblob #1

merged 3 commits into from
May 4, 2023

Conversation

vlaci
Copy link
Contributor

@vlaci vlaci commented May 4, 2023

@vlaci vlaci force-pushed the wip-binding branch 6 times, most recently from 611579f to 77455a9 Compare May 4, 2023 14:16
@qkaiser
Copy link
Contributor

qkaiser commented May 4, 2023

That's a lot of infra for a single function exposed from Rust :) I hope we'll move more things to Rust to make use of it.

I don't see any obvious issues since it's a copy paste with a few adjustments. Should we expect a matching MR in unblob that removes https://github.com/onekey-sec/unblob/tree/main/rust ?

@vlaci
Copy link
Contributor Author

vlaci commented May 4, 2023

That's a lot of infra for a single function exposed from Rust :) I hope we'll move more things to Rust to make use of it.

I don't see any obvious issues since it's a copy paste with a few adjustments. Should we expect a matching MR in unblob that removes https://github.com/onekey-sec/unblob/tree/main/rust ?

I wanted it to be as clean as possible. Even if we never touch this again, the better to keep it in a tidy state :)

Yep, if it reaches PyPI, we can remove that one, and make Unblob a pure package without architecture constrants

@vlaci vlaci force-pushed the wip-binding branch 8 times, most recently from daf202b to e11c602 Compare May 4, 2023 16:26
- Code is from https://github.com/onekey-sec/unblob/tree/main/rust
- Initialized packaging
- Pyright-specific changes to ginore issues from native code
- Pre-commit hooks
@vlaci vlaci enabled auto-merge May 4, 2023 22:02
@vlaci vlaci force-pushed the wip-binding branch 2 times, most recently from 16a8437 to fc81a94 Compare May 4, 2023 22:13
vlaci added 2 commits May 5, 2023 00:20
- One check -> test -> build -> release pipeline
- Auto-update nix environment job (experimental)
@vlaci vlaci merged commit 5c94f51 into main May 4, 2023
@vlaci vlaci deleted the wip-binding branch May 4, 2023 22:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants