Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in FloatNode.__eq__ #90

Closed
wants to merge 2 commits into from
Closed

Fix bug in FloatNode.__eq__ #90

wants to merge 2 commits into from

Conversation

tamuhey
Copy link

@tamuhey tamuhey commented Dec 1, 2019 •
edited
Loading

from #89

Before this PR, the following code raises

from omegaconf.nodes import FloatNode

x = FloatNode()
x == 1

After this PR, not raise.

@tamuhey tamuhey changed the title fix #89 Fix bug in FloatNode.__eq__ Dec 1, 2019
@omry
Copy link
Owner

omry commented Dec 1, 2019

Thanks!
I have a few requests, but let's park it until I land #87, It has a lot of changes to nodes.py.

@tamuhey tamuhey mentioned this pull request Dec 1, 2019
Closed
@omry
Copy link
Owner

omry commented Dec 6, 2019

I fixed this as a part of #86 while improving test coverage.
Test for the patch, closing.

@omry omry closed this Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamuhey @omry