-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs edits #706
Docs edits #706
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
docs/source/custom_resolvers.rst
Outdated
Custom resolvers support variadic argument lists in the form of a comma separated list of zero or more values. | ||
Whitespaces are stripped from both ends of each value ("foo,bar" is the same as "foo, bar "). | ||
Custom resolvers support variadic argument lists in the form of a comma-separated list of zero or more values. | ||
In a variadic argument list, whitespace is stripped from the ends of each value ("foo,bar" gives the same result as "foo, bar "). | ||
You can use literal commas and spaces anywhere by escaping (:code:`\,` and :code:`\ `), or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a glance, :code:
,`` looks like a surrounding double backticks. If so, I suggest we switch to double backtick for consistency with the rest of the doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doc build fails if I use double backticks for the one with the space. I think that the backslash is causing some escaping problem.
docs/source/structured_config.rst
Outdated
>>> # Okay, "20" can be converted to an int | ||
>>> conf.ints["e"] = "20" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are thinking about deprecating the automatic conversion on assignment because it triggers a typing error (#459).
Don't document the automatic conversion, just the straight forward valid assignment and the hard error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in a23fbac.
For the other instance, using double backticks seems to cause sphinx-build to fail.
Co-authored-by: Omry Yadan <[email protected]>
You can use literal commas and spaces anywhere by escaping (:code:`\,` and :code:`\ `), or | ||
Custom resolvers support variadic argument lists in the form of a comma-separated list of zero or more values. | ||
In a variadic argument list, whitespace is stripped from the ends of each value ("foo,bar" gives the same result as "foo, bar "). | ||
You can use literal commas and spaces anywhere by escaping (``\,`` and :code:`\ `), or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs build fails if I change the :code:\
to use double backticks. I think the backslash is causing an escaping problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (assuming everything passes).
You can use literal commas and spaces anywhere by escaping (:code:`\,` and :code:`\ `), or | ||
Custom resolvers support variadic argument lists in the form of a comma-separated list of zero or more values. | ||
In a variadic argument list, whitespace is stripped from the ends of each value ("foo,bar" gives the same result as "foo, bar "). | ||
You can use literal commas and spaces anywhere by escaping (``\,`` and :code:`\ `), or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, ok.
Related to #689Closes #689