Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs edits #706

Merged
merged 13 commits into from
May 12, 2021
Merged

Docs edits #706

merged 13 commits into from
May 12, 2021

Conversation

Jasha10
Copy link
Collaborator

@Jasha10 Jasha10 commented May 6, 2021

Related to #689
Closes #689

Copy link
Owner

@omry omry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@Jasha10 Jasha10 requested a review from omry May 8, 2021 03:57
Custom resolvers support variadic argument lists in the form of a comma separated list of zero or more values.
Whitespaces are stripped from both ends of each value ("foo,bar" is the same as "foo, bar ").
Custom resolvers support variadic argument lists in the form of a comma-separated list of zero or more values.
In a variadic argument list, whitespace is stripped from the ends of each value ("foo,bar" gives the same result as "foo, bar ").
You can use literal commas and spaces anywhere by escaping (:code:`\,` and :code:`\ `), or
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a glance, :code:,`` looks like a surrounding double backticks. If so, I suggest we switch to double backtick for consistency with the rest of the doc.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc build fails if I use double backticks for the one with the space. I think that the backslash is causing some escaping problem.

Comment on lines 287 to 288
>>> # Okay, "20" can be converted to an int
>>> conf.ints["e"] = "20"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are thinking about deprecating the automatic conversion on assignment because it triggers a typing error (#459).
Don't document the automatic conversion, just the straight forward valid assignment and the hard error.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in a23fbac.

Jasha10 and others added 3 commits May 11, 2021 18:14
You can use literal commas and spaces anywhere by escaping (:code:`\,` and :code:`\ `), or
Custom resolvers support variadic argument lists in the form of a comma-separated list of zero or more values.
In a variadic argument list, whitespace is stripped from the ends of each value ("foo,bar" gives the same result as "foo, bar ").
You can use literal commas and spaces anywhere by escaping (``\,`` and :code:`\ `), or
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs build fails if I change the :code:\ to use double backticks. I think the backslash is causing an escaping problem.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, ok.

@Jasha10 Jasha10 requested a review from omry May 11, 2021 23:37
Copy link
Owner

@omry omry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (assuming everything passes).

You can use literal commas and spaces anywhere by escaping (:code:`\,` and :code:`\ `), or
Custom resolvers support variadic argument lists in the form of a comma-separated list of zero or more values.
In a variadic argument list, whitespace is stripped from the ends of each value ("foo,bar" gives the same result as "foo, bar ").
You can use literal commas and spaces anywhere by escaping (``\,`` and :code:`\ `), or
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, ok.

@Jasha10 Jasha10 merged commit d67f69d into omry:master May 12, 2021
@Jasha10 Jasha10 deleted the docs_edits branch May 12, 2021 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make a full pass over the 2.1 docs before release
2 participants