Patch changeListener to better sync self.current #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashed
force-pushed
the
patch-changeListener
branch
from
6146b58 to
380e4a4
Compare
|
rebased and squashed commits. |
When a cursor updates, any cursors not in the keypath to the updated cursor will become stale. Patch changeListener to better sync self.current when a stale cursor updates, and when a un-stale cursor updates.
dashed
force-pushed
the
patch-changeListener
branch
from
380e4a4 to
7f06ee7
Compare
|
I'm currently revising tests. |
|
Need to check this out, but immediately LGTM. The changes seem to make sense. I'll need to make a local copy and check it out with different test cases though. Maybe revise some tests. |
|
I revised the tests. Feel free to change them for the better. |
|
Good job. 👍 I'll look more into it later today, when I'm not so occupied and distracted. |
dashed
added a commit
to dashed/immstruct
that referenced
this pull request
Dec 18, 2014
Remove noop behaviour at original changeListener. This will be re-applied when omniscientjs#13 gets merged.
mikaelbr
added a commit
that referenced
this pull request
Dec 20, 2014
Patches changeListener to better sync self.current
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch changeListener to better sync
self.currentwhen it's out of sync and when it's not.Closes #12