Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Google OpenID Connect #520

Closed
wants to merge 1 commit into from
Closed

Fixes Google OpenID Connect #520

wants to merge 1 commit into from

Conversation

fredericcambon
Copy link

This PR fixes the google openid connect (#494, #477 for more information)

It is my first contribution to this repo, could you ensure everything is in order?

@tonylampada
Copy link

Following this. Hope it works out.

@tonylampada
Copy link

I can confirm that it's possible to login using google-openidconnect with this patch.

The changes I had to do in my django application are here [1]
Also I had to create a project with a clientid/secret as instructed here [2]
Important: Authentication only worked after I enabled the "Google +" API for that project

[1] freedomsponsors/www.freedomsponsors.org@e45f986
[2] https://developers.google.com/accounts/docs/OpenIDConnect

The problem now is that, if I try to login on "/login/google-openidconnect", it will create a new User instead of authenticating into the previously existing one. Is there an easy solution for this problem?

/cc @omab - perhaps you can give me a pointer here too?

@tonylampada
Copy link

OK, no need. Just had to rtfm and use Associate Users by email.

Just for the record here's the relevant changes

@omab
Copy link
Owner

omab commented Apr 2, 2015

Closing, very broken tests.

@omab omab closed this Apr 2, 2015
@abompard
Copy link
Contributor

abompard commented Apr 3, 2015

Google says basic OpenID will stop working in 12 days, is there a way to auth with Google without requesting an API key from them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants