Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Timestamp Parsing Error that renders Invalid Datetime #252

Merged
merged 2 commits into from
May 3, 2024

Conversation

jyyyeung
Copy link
Contributor

Fixes issue #206

  1. Updated dateToZulu filter to return "" whenever the string is invalid
  2. added fallback timestamp parsing functions from luxon when the default method fromISO() raises an error
  3. Update sitemap to also use dateToZulu filter

@oleeskild
Copy link
Owner

awesome, thank you very much for contributing!

@BG6LH
Copy link

BG6LH commented Mar 12, 2025

Thanks @jyyyeung !

I noticed that there might be an issue here. It seems that Luxon doesn't have a dateTime.fromHTML() function. So when I tried using a date format like 2025-03-12, 11:30:00, it didn't parse correctly and showed an error in the console.

Just wanted to bring this to your attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants