Add result_quantity to open_until #6290
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 1053dc6 in 36 seconds
More details
- Looked at
125lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. src/mahoji/lib/abstracted_commands/openCommand.ts:65
- Draft comment:
Consider adding a check to see if the user already owns theopenUntilitem and handle it appropriately, possibly with a confirmation prompt. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The code previously had this check but it was deliberately removed in this PR. The change to support multiple quantities suggests this check is no longer relevant - users may want multiple copies of items. The removal seems intentional based on the other changes. Making this suggestion would be going against an explicit design decision.
Maybe there are some items that still shouldn't be duplicated even with the new multiple quantity feature? The original check was specifically for clue items.
The PR author explicitly removed this check while adding quantity support. If certain items need special handling, that should be a separate feature request with specific requirements, not a vague suggestion to add back removed code.
Delete this comment as it suggests reverting an intentional change without strong justification.
Workflow ID: wflow_wRu3B50SNC4pIPi1
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| export const RawSQL = { | ||
| updateAllUsersCLArrays: () => `UPDATE users | ||
| SET ${u.cl_array} = ( | ||
| SELECT (ARRAY(SELECT jsonb_object_keys("${u.collectionLogBank}")::int)) | ||
| ) | ||
| WHERE last_command_date > now() - INTERVAL '1 week';`, | ||
| SET ${u.cl_array} = ( | ||
| SELECT ARRAY(SELECT jsonb_object_keys("${u.collectionLogBank}")::int) | ||
| ) | ||
| WHERE last_command_date > now() - INTERVAL '1 week';`, | ||
|
|
||
| updateCLArray: (userID: string) => `UPDATE users | ||
| SET ${u.cl_array} = ( | ||
| SELECT (ARRAY(SELECT jsonb_object_keys("${u.collectionLogBank}")::int)) | ||
| ) | ||
| WHERE ${u.id} = '${userID}';` | ||
| SET ${u.cl_array} = ( | ||
| SELECT ARRAY(SELECT jsonb_object_keys("${u.collectionLogBank}")::int) | ||
| ) | ||
| WHERE ${u.id} = '${userID}';` | ||
| }; | ||
|
|
There was a problem hiding this comment.
Is this an intentional change?
There was a problem hiding this comment.
Yeah this was intentional. Some of the openings were not showing to the user, and I was getting this error message logged:
ERROR: operator does not exist: integer[] & integer[]
Removing the extra pair of parentheses and running linting helped resolve the issue and fixed the errors. If you think it's not needed though you can remove these changes.
There was a problem hiding this comment.
That error sounds like it may be because you dont have the intarray extension installed on your postgres. Try running CREATE EXTENSION intarray; in your db. I dont see any reason removing parens would fix that error though too, so i would try undo the changes and see if it works without it
There was a problem hiding this comment.
The issue is when collection log is getting a lot of updates, here because of opening 5000 caskets at once. I guess this might be splitting up the sql lookup, so concatting is required? Bit annoying to require everyone to install sql extensions to setup bot
Important
Add
result_quantityoption toopenCommandto specify target item count before stopping, with handling inabstractedOpenUntilCommand.result_quantityoption toopenCommandinopen.tsto specify target item count before stopping.abstractedOpenUntilCommandinopenCommand.tsto handleresult_quantity, breaking loop when target count is reached.result_quantityis a positive integer inabstractedOpenUntilCommand.abstractedOpenUntilCommandto 10000 for opening items.This description was created by
for 1053dc6. It will automatically update as commits are pushed.