Highlight the selected filter #22
Merged
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndicator Minor bug: Possible to get two if you go back to a default okcupid filter, but our filter is still in play too, so that seems reasonable. But with that approach of "double selection" we should never deactivate the default filters' indicators.
ojchase
added a commit
that referenced
this pull request
Feb 20, 2021
Highlight the selected filter Fixes #15 Manipulates the elements to get the class that the OKCupid CSS uses to show the filter indicator. When a user-defined filter is selected, it receives the necessary class. When a different filter is selected, it loses it. This does not touch the default agree/disagree/find out filters. In the normal case where one of those is selected, you'll see two indicators: one for the question listed as filtered by OKCupid (agree/disagree/find out) and another for additional filtering performed by this extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15
Manipulates the elements to get the class that the OKCupid CSS uses to show the filter indicator. When a user-defined filter is selected, it receives the necessary class. When a different filter is selected, it loses it.
This does not touch the default agree/disagree/find out filters. In the normal case where one of those is selected, you'll see two indicators: one for the question listed as filtered by OKCupid (agree/disagree/find out) and another for additional filtering performed by this extension.