Instances in UI - fetch all in a single query #2537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alonkeyval
approved these changes
Mar 9, 2025
BenElferink
changed the title
alonkeyval
reviewed
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the way we get the instances/healthy condition for instrumented workloads.
Previously we would get them in the same query as paginated instrumentation configs, then we changed it so we would 1st paginate the instrumentation configs, and then get the instances for each workload individually. This definitely improved load-time for instrumented workloads in the UI, but still acted up with instances.
So now, we finish paginating instrumentation configs, and then we get all instances in a single query.
How Has This Been Tested?
Kubernetes Checklist