command: introduce DebugPrintf #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce DebugPrintf which can be used to give contextual and debug information when things go wrong and we need to observe them, when verbose or `DEBUG=true` is set in the environment. So far added debugging prints when parsing the .driverc file. It prints out the: [<FILE>:<FUNCTION>:<LINE_NUMBER>] Prefix a drive invocation with `DEBUG=true` ```shell $ DEBUG=true drive list share-testing/ [/Users/emmanuelodeke/go/src/github.com/odeke-em/drive/cmd/drive/main.go:main.discoverContext:1857] contextPath: /Users/emmanuelodeke/[email protected]/share-testing [/Users/emmanuelodeke/go/src/github.com/odeke-em/drive/cmd/drive/main.go:main.discoverContext:1867] driveRoot: "/Users/emmanuelodeke/[email protected]" relToRoot: "" [/Users/emmanuelodeke/go/src/github.com/odeke-em/drive/src/rc.go:github.com/odeke-em/drive/src.ResourceMappings:92] RCPath: /Users/emmanuelodeke/[email protected]/share-testing/.driverc [/Users/emmanuelodeke/go/src/github.com/odeke-em/drive/src/rc.go:github.com/odeke-em/drive/src.ResourceMappings:108] parsedContent from "/Users/emmanuelodeke/[email protected]/share-testing/.driverc" { "global": { "depth": -1 } } [Commands.List] #0 "/share-testing" -- owner 175.00B 0Bwu8laYc9RTPa28zVk9Td2hTVWc 2016-06-30 15:32:25 +0000 UTC /share-testing/SciqPCKrhi.go -- owner 309.00B 0Bwu8laYc9RTPTXRYblNqQXBSQzQ 2016-02-03 08:12:15 +0000 UTC /share-testing/outf.go -s owner 39.70KB 0Bwu8laYc9RTPOVNSeElpdFBpS2M 2012-02-02 12:00:00 +0000 UTC /share-testing/ComedyPunchlineDrumSound.mp3 ``` It will alleviate #829 since the reporter could then investigate and see the .gd path and .driverc paths that were being read from.
odeke-em
added a commit
that referenced
this pull request
Jan 7, 2017
Updates #830. Replace `DEBUG` with `DRIVE_DEBUG` to avoid clashes with other programs that might need the `DEBUG` flag. `DRIVE_DEBUG` makes it clear that this debug is only for drive.
This was referenced Jan 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce DebugPrintf which can be used to give
contextual and debug information when things go wrong
and we need to observe them, when verbose or
DEBUG=trueis set in the environment.
So far added debugging prints when parsing the .driverc file.
It prints out the:
[::<LINE_NUMBER>]
Prefix a drive invocation with
DEBUG=trueIt will alleviate #829
since the reporter could then investigate and see the .gd path and
.driverc paths that were being read from.