Fix O_CLOEXEC tests when compiling to bytecode #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aantron
changed the title
Yes, it does. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@olafhering, could you test this branch,
openfile-tests, to see if it fixes #729 for you?The problem was caused by this line:
lwt/test/unix/test_lwt_unix.cppo.ml
Line 23 in fb00be1
which does not pass a program name to the child process. When the child process was a native-code OCaml program, it did not try to access that first argument. But, when the child is a bytecode copy of the tester, the bytecode runtime fails if the first argument is not present. It seems to work fine with the empty string as argument, however.
I added a Travis row for testing on a bytecode-only compiler.
Fixes #729.