Fix references to shadowed items #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output for 'shadowed.mli' is right but the warnings shouldn't occur. The output for 'shadowed_through_open.mli' is wrong.
Before this patch, Odoc_xref2.Env doesn't implement shadowing and several elements of the same kind with the same name could be represented.
jonludlam
reviewed
Jun 3, 2021
| @@ -1,5 +1,25 @@ | |||
| A quick test to repro the issue found in #587 | |||
|
|
|||
| $ ./build.sh | |||
| File "odoc_bug__a_intf.cmt": | |||
There was a problem hiding this comment.
What's going on here? I don't understand why this would start failing now?
There was a problem hiding this comment.
Fixed. I misunderstood lookup by identifier in the environment. The previous code was removing shadowed items from the environment but we need to keep them in the case of aliases to the same name. We only need to remove them from "lookup by name" results.
Shadowing should only be implemented when looking up by name. This is important for aliases to an item of the same name.
|
The fastly outage is causing the test failures IFAICT |
|
Most CI jobs passed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #648
This PR implements shadowing when resolving submodules. Before, several items with the same name were added to the environment, which caused the warnings.
The notion of scope didn't change: the whole signature is added to the environment before any reference is resolved (including opens and includes).