Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak syntax for page name refs #622

Merged
merged 4 commits into from
Mar 11, 2021

Conversation

lubegasimon
Copy link
Collaborator

@lubegasimon lubegasimon commented Mar 5, 2021

Fixes #590

@lubegasimon lubegasimon requested a review from Julow March 5, 2021 11:18
@jonludlam
Copy link
Member

It'd be good to add some test cases to the parser tests - test/parser/test.ml, since when we remove the parser these tests will go with it.

@lubegasimon lubegasimon force-pushed the tweak-syntax-for-page-name-refs branch from e4a86e6 to d6d800b Compare March 7, 2021 13:23
@lubegasimon lubegasimon marked this pull request as ready for review March 7, 2021 13:24
@lubegasimon lubegasimon force-pushed the tweak-syntax-for-page-name-refs branch from d6d800b to 8ad5831 Compare March 11, 2021 07:57
@lubegasimon
Copy link
Collaborator Author

It'd be good to add some test cases to the parser tests - test/parser/test.ml, since when we remove the parser these tests will go with it.

Indeed, I’ll surely address this in an independent PR

Signed-off-by: lubegasimon <[email protected]>
@jonludlam
Copy link
Member

Thanks!

@jonludlam jonludlam merged commit 18f8aec into ocaml:master Mar 11, 2021
@lubegasimon lubegasimon deleted the tweak-syntax-for-page-name-refs branch August 13, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable references to refer to pages with '.' or '-'
3 participants