Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser work #621

Merged
merged 14 commits into from
Mar 4, 2021
Merged

Parser work #621

merged 14 commits into from
Mar 4, 2021

Conversation

jonludlam
Copy link
Member

Initial work so the parser can be extracted into a separate library.

Julow
Julow approved these changes Mar 4, 2021
View reviewed changes
Copy link
Collaborator

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The parser for references should be splitted out of model too.

src/parser/error.mli Outdated

type 'a with_warnings = { value : 'a; warnings : t list }

type warning_accumulator = t list ref
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type should be abstract.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@jonludlam jonludlam merged commit d5612dc into ocaml:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julow Julow Julow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonludlam @Julow