Fix generated html for conjunctive types #353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Octachron
force-pushed
the
conjunctive_types
branch
2 times, most recently
from
2664304 to
8c68485
Compare
Octachron
force-pushed
the
conjunctive_types
branch
from
8c68485 to
a2433d2
Compare
|
Well, you learn something new every day :-) I'd not come across these types before. |
jonludlam
reviewed
May 1, 2019
|
|
||
|
|
||
| (* Conjunctive types: dune compilation scheme exposes a bug in old | ||
| versions of the compiler *) |
There was a problem hiding this comment.
I was thinking of ocaml/ocaml#7629 , but there were other issues with conjunctive types in older version of ocaml : ocaml/ocaml#7496 for instance. The short explanation is that conjunctive types are intended as type-checking artefacts and using them directly can make compilation break in unexpected way.
|
Indeed, conjunctive types are not really intended to be used directly. Honestly, the value of this PR is more in the documentation of the unusal interpration of constructor arguments for polymorphic variants than in the fix itself. |
|
Right. Thanks very much for this! |
|
Rebased in #358 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the html generated for conjunctive types, for instance
which are currently printed as
because the list of arguments of the polymorphic variant constructor is interpreted as a product instead of a conjunction.