Remove abusive normalization in docstrings references #2159
Conversation
|
Hi @EmileTrotignon! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
There was a problem hiding this comment.
Looks good to me :) For context, this goes with ocaml-doc/odoc-parser#12.
The CI is failing because the test test/failing/tests/unstable_docstrings.mli was expecting this reference to be escaped in the middle: {!serve_with_handler]/{!serve}}. I think the whole test can be removed.
Should this error be handled by odoc-parser instead? If not we can move the test from |
|
Adding such a test to There's no error from the pov of odoc-parser. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
This fixes the following failure : formatting
(** {! refref [ } *)into(** {! refref \[ } *)