Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add excel tools #63

Merged
merged 1 commit into from
Oct 1, 2024
Merged

feat: add excel tools #63

merged 1 commit into from
Oct 1, 2024

Conversation

g-linville
Copy link
Collaborator

@g-linville g-linville commented Sep 30, 2024

This adds a set of six Excel tool to work with spreadsheet files in the user's OneDrive.
The API refers to a spreadsheet file as a workbook, and a spreadsheet within the workbook (one of the tabs at the bottom of the screen) as a worksheet. I stuck with that naming in this code and in the tool. The LLM doesn't seem confused about it.

Signed-off-by: Grant Linville <[email protected]>
@g-linville g-linville marked this pull request as ready for review September 30, 2024 18:17
Copy link
Contributor

@drpebcak drpebcak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we don't want to nest these too far, but I wonder if it might be time to drop these under a 'microsoft365' folder or something like that, to make it clear that these tools for excel, outlook, etc are for the m365 versions.

@StrongMonkey
Copy link
Contributor

I know we don't want to nest these too far, but I wonder if it might be time to drop these under a 'microsoft365' folder or something like that, to make it clear that these tools for excel, outlook, etc are for the m365 versions.

Good point, or something like o365-excel.

@g-linville
Copy link
Collaborator Author

I think a reorganization of the folders should be discussed with the team. For now, I'm going to merge this.

@g-linville g-linville merged commit 7242028 into obot-platform:main Oct 1, 2024
@g-linville g-linville deleted the excel branch October 1, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants