enhance: add Outlook Mail code tools #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
g-linville
requested review from
thedadams,
njhale,
StrongMonkey and
iwilltry42
thedadams
approved these changes
Aug 27, 2024
Comment on lines
6
to
7
| ReadOnlyScopes = []string{"TODO"} | ||
| AllScopes = []string{"TODO"} |
There was a problem hiding this comment.
Do these need to be replaced with something else? If not, can we add a comment explaining?
There was a problem hiding this comment.
Whoops lol. Yeah this proves that we probably don't need to specify scopes. I think I'll add them in anyway, in case we for some reason change how we handle authn/z.
Signed-off-by: Grant Linville <[email protected]>
cjellick
reviewed
Aug 28, 2024
| #!${GPTSCRIPT_TOOL_DIR}/bin/gptscript-go-tool listMailFolders | ||
|
|
||
| --- | ||
| Name: listMessages |
There was a problem hiding this comment.
why do you use the word message instead of email throug out this?
There was a problem hiding this comment.
An individual email is referred to as a message in the Graph API, which is why I stuck with that naming. Though I could see how it could be less helpful to the LLM. I can just update the naming within the tool.gpt file if you want, since that's all the LLM will see.
njhale
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much like the Outlook Calendar code tools, these aren't being used anywhere yet. I want to get them merged first, and then switch the existing
manageandreadtools over to using these.