enhance: Outlook Calendar code tools #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-linville
force-pushed
the
outlook-calendar-code-tool
branch
from
6ff6c59 to
9e1af39
Compare
Signed-off-by: Grant Linville <[email protected]>
g-linville
force-pushed
the
outlook-calendar-code-tool
branch
from
6f439d7 to
d608fdb
Compare
Signed-off-by: Grant Linville <[email protected]>
g-linville
commented
Aug 26, 2024
|
|
||
| switch command { | ||
| case "listCalendars": | ||
| if err := commands.ListCalendars(context.Background()); err != nil { |
There was a problem hiding this comment.
Right now I'm just using context.Background() everywhere, but this can be easily changed. Just not sure if it is something that needs to be changed.
g-linville
commented
Aug 26, 2024
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
g-linville
changed the title
g-linville
requested review from
thedadams,
njhale,
StrongMonkey and
iwilltry42
StrongMonkey
approved these changes
Aug 26, 2024
thedadams
reviewed
Aug 26, 2024
|
|
||
| switch command { | ||
| case "listCalendars": | ||
| if err := commands.ListCalendars(context.Background()); err != nil { |
Signed-off-by: Grant Linville <[email protected]>
thedadams
approved these changes
Aug 27, 2024
apis/outlook/calendar/code/main.go
Outdated
Comment on lines
121
to
122
| startPtr *time.Time | ||
| endPtr *time.Time |
There was a problem hiding this comment.
Typically, pointers aren't used for time.Time. Sort of why there is a time.Time.IsZero() method.
Signed-off-by: Grant Linville <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a set of code-based tools for Outlook Calendar. I am not yet replacing the existing
manageandreadtools. I'm going to wait until this is merged, and then change those over to start using this.The code is basically organized into three "layers":
main.gofile, which figures out which command was called and reads environment variablescommandspackage, which initializes the MS Graph client and handles outputgraphpackage, which handles API calls using the MS Graph SDK