GitHub Issue #183 - Improve quoted ns metadata handling #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagged literal values in namespace metadata are missing the hash '#'. formatNodes function handles the edge case for adding '#' text tot .tag nodes. However, ns metadata doesn't use formatNodes, instead it collects the values as text. Thus, we need to add the same edge case handling to the text collecting.
This commit improves quoted namespace metadata value handling. Pull Reuqest oakmac#182 added quoted ns metadata value handling for nodes with children (maps, lists etc.) but didn't address all the possible types a wrap node body might have. This commit checks if the skip target candidate node has children, and if yes it picks the last child and repeats the check until it finds the correct skip target.
rap1ds
changed the title
This was referenced Feb 27, 2025
|
These bug finds + fixes are great! Thank you for the help 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built on top of PR #185
This PR improves quoted namespace metadata value handling.
Pull Request #182 added quoted ns metadata value handling for nodes with children (maps, lists etc.) but didn't address all the possible types a wrap node body might have.
This commit checks if the skip target candidate node has children, and if yes it picks the last child and repeats the check until it finds the correct skip target.