Avoid logging secrets in Engine debug logs #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mz-pdm
requested review from
emesika,
mwperina,
ahadas,
bennyz,
michalskrivanek,
oliel,
sgratch,
smelamud,
didib and
ljelinkova
as code owners
smelamud
reviewed
Sep 13, 2022
.../manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SecretsWrapper.java
Outdated
Show resolved
Hide resolved
smelamud
reviewed
Sep 13, 2022
...ager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExtractOvaCommand.java
Outdated
Show resolved
Hide resolved
mz-pdm
force-pushed
the
logging-secrets#
branch
from
0426559 to
53eb4d2
Compare
ljelinkova
approved these changes
Sep 21, 2022
smelamud
reviewed
Sep 21, 2022
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateOvaCommand.java
Outdated
Show resolved
Hide resolved
smelamud
reviewed
Sep 21, 2022
.../manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java
Outdated
Show resolved
Hide resolved
smelamud
reviewed
Sep 21, 2022
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HasNvramDataQuery.java
Outdated
Show resolved
Hide resolved
smelamud
reviewed
Sep 21, 2022
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
Outdated
Show resolved
Hide resolved
smelamud
reviewed
Sep 21, 2022
...dsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateBrokerVDSCommand.java
Show resolved
Hide resolved
mz-pdm
force-pushed
the
logging-secrets#
branch
from
53eb4d2 to
7c086d6
Compare
This class allows wrapping values that shouldn’t be exposed in logs. Its toString method returns just a placeholder and the real value must be retrieved using getValue method. This is useful for wrapping values such as TPM data, secure boot NVRAM data, or passwords passed in cloud init, in order to prevent them from exposing in DEBUG logs. See the followup patches for particular examples.
The password is currently replaced in meta data but it occurs in user data. Let’s replace it there too.
mz-pdm
force-pushed
the
logging-secrets#
branch
from
7c086d6 to
9099867
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #641. See also oVirt/vdsm-jsonrpc-java#24.