Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'geography' dropdown so that the user can see specified geos rather than just the finest-available. #616

Closed
Tracked by #534
cgettings opened this issue Apr 11, 2023 · 6 comments

Comments

@cgettings
Copy link
Contributor

No description provided.

@cgettings
Copy link
Contributor Author

@mmontesanonyc, @sportsmanam On dev. Feel free to try and break.

@mmontesanonyc
Copy link
Contributor

Looking good. I even tested on variable NYCKids stuff (Children with asthma) and it correctly changes year-specific NYCKIDS geo on time change. Really good handling of things - if no map, I'm getting good reversion to Summary on indicator change.

One thing I think this lets us do is consolidate some NTA-level indicators that are "separate indicators" (asthma ED visits, HVI). We could add the NTA-level data to the general indicator, get rid of the "by NTA" indicator.

Planning to add Boroughs to the dropdown? I think it'd be good.

@cgettings
Copy link
Contributor Author

Yeah, I'll get on that after lunch.

@cgettings
Copy link
Contributor Author

@mmontesanonyc Just added boro. Had to troubleshoot and re-create the boro topojson, but it's all good now.

@mmontesanonyc
Copy link
Contributor

I haven't found myself able to break this - if you agree, I think it's ready for primetime.

One thing that this makes me think about is menu styles. I don't think this is anything that we should work on with this project, but flagging for future consideration and possible work with our contractor/partners. Persisting selection names in the menu headers (eg, so that when you choose CD in geography, then CD is what shows in that dropdown button) would be interesting, and would let us remove some information from the chart title/subtitle. This might require a lot of changes to button styles, and they might need labels that look differently, so I don't want to rush it - but want to consider it.

@mmontesanonyc
Copy link
Contributor

Closing. Great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants