Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install incompatibility add ons #17779

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hwf1324
Copy link
Contributor

@hwf1324 hwf1324 commented Mar 6, 2025

Link to issue number:

block by #17778

Fixed #17655
Fixed #17746
Fixed #17767

Summary of the issue:

When checking add-on compatibility, somehow bundle._hasOverriddenCompat is False when listItemVM.model.overrideIncompatibility is True?

Description of user facing changes

Add-ons that overwrite incompatibilities can be installed from the Add-on Store.

Description of development approach

Removed exception thrown when duplicate overrides were incompatible.

Testing strategy:

Successfully installed manually from the add-on store to override incompatible add-ons.

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@hwf1324 hwf1324 requested a review from a team as a code owner March 6, 2025 06:10
@hwf1324 hwf1324 requested a review from seanbudd March 6, 2025 06:10
@seanbudd
Copy link
Member

seanbudd commented Mar 6, 2025

@hwf1324 I'd prefer if you revert the previous change you made. I think this guard is intentional, like the previous guard that was modified.

@hwf1324
Copy link
Contributor Author

hwf1324 commented Mar 6, 2025

I'd prefer if you revert the previous change you made. I think this guard is intentional, like the previous guard that was modified.

@seanbudd How about changing the exception thrown to log.debugWarning? But this is obviously not logical when retrying the download. And it would also import logHandler.

And I don't understand the reason for doing so?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants