Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix description line not truncating in columnar menu #739

Merged
merged 6 commits into from
Feb 2, 2024

Conversation

maxomatic458
Copy link
Contributor

fixes #738

@maxomatic458 maxomatic458 marked this pull request as draft February 1, 2024 20:37
@fdncred
Copy link
Contributor

fdncred commented Feb 1, 2024

Do you have a nushell branch that I can test this out in?

@maxomatic458
Copy link
Contributor Author

not right now, ill finish this PR tomorrow and make a nushell branch so you can test it.

@fdncred
Copy link
Contributor

fdncred commented Feb 1, 2024

ok, sounds good. thank you!

@maxomatic458 maxomatic458 marked this pull request as ready for review February 2, 2024 20:46
@maxomatic458
Copy link
Contributor Author

@fdncred the PR should be ready now, you can test it here https://github.com/maxomatic458/nushell/tree/testing

@fdncred
Copy link
Contributor

fdncred commented Feb 2, 2024

Looks good. thanks!

@fdncred fdncred merged commit f244736 into nushell:main Feb 2, 2024
6 checks passed
@maxomatic458 maxomatic458 deleted the match-text branch February 3, 2024 10:37
ClementNerma pushed a commit to ClementNerma/reedline that referenced this pull request Feb 6, 2024
* add builder functions

* fix description wrap

* fmt

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Columnar Menu does not truncate the description, leading to weird prompt rendering
2 participants