fix(nextjs): ensure eslint-config-next matches Next.js 14 and 15 versions
#30259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 89d30b2.
☁️ Nx Cloud last updated this comment at |
The `create-nx-workspace` command with the Next.js preset currently installs `next@15` but incorrectly adds `eslint-config-next@14`, leading to potential ESLint compatibility issues. This fix ensures that `eslint-config-next@15` is installed when using Next.js 15.
…on for Next.js 14 and 15 Enhanced the logic to determine the installed Next.js version and ensure the appropriate `eslint-config-next` devDependency is added accordingly: - Next.js 15 - `eslint-config-next@15` - Next.js 14 - `eslint-config-next@14` This further refines the previous fix by dynamically selecting the correct ESLint configuration, preventing potential compatibility issues.
tuffz
force-pushed
the
fix-next-eslint-config-based-on-nextjs-version
branch
from
7560de3 to
89d30b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the previous fix that ensured
eslint-config-nextwas correctly installed when using Next.js 15. #30258Now, the logic has been further refined to dynamically determine the installed Next.js version and install the corresponding
eslint-config-nextversion accordingly.Current Behavior
next@~15.1.4is installed[email protected]is installed (incorrect for Next.js 15)Expected Behavior
If Next.js 15 is detected -> [email protected] is installed
If Next.js 14 is detected -> [email protected] is installed
GitHub Repo
https://github.com/tuffz/new-nx-with-preset-nextjs
Steps to Reproduce
npx create-nx-workspace@latest --preset=nextpackage.jsonand check the installed dependenciesnext@~15.1.4is installed[email protected]is installedRelated Issue(s)
Fixes #30257 (& #30258)