fix: check if dependencies & devDependencies exist before deleting dep #30224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@GrandSchtroumpf I think the linked issue is not the correct one. |
|
@samir-ajdarpasic I have updated thx |
| for (const dep of dependencies) { | ||
| delete json.dependencies[dep]; | ||
| } | ||
| json.dependencies = sortObjectByKeys(json.dependencies); |
There was a problem hiding this comment.
Since we are improving this code if there are no dependencies we could also remove the dependencies instead of attempting to sort it.
| for (const devDep of devDependencies) { | ||
| delete json.devDependencies[devDep]; | ||
| } | ||
| json.devDependencies = sortObjectByKeys(json.devDependencies); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
removeDependenciesFromPackageJsontries to delete dep fromundefinedif there is nodependenciesordevDependenciesin package.jsonExpected Behavior
First check if
dependenciesordevDependenciesexistsRelated Issue(s)
Fixes #30222