fix(vite): allow force ignore of logs from nxViteTsPaths plugin #29320 #30200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit fe8ac38.
☁️ Nx Cloud last updated this comment at |
4 tasks
Coly010
force-pushed
the
vite/ts-paths-logging
branch
from
371c907 to
0a2a6ba
Compare
Coly010
changed the title
leosvelperez
approved these changes
Feb 27, 2025
| @@ -24,6 +24,7 @@ import { isUsingTsSolutionSetup } from '@nx/js/src/utils/typescript/ts-solution- | |||
| export interface nxViteTsPathsOptions { | |||
| /** | |||
| * Enable debug logging | |||
| * If set to 'force-ignore', it will always ignore the debug logging even when `--verbose` or `NX_VERBOSE_LOGGING` is set to true. | |||
There was a problem hiding this comment.
We should remove the mention of force-ignore
Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When Vite build is run where:
nxViteTsPathsplugin is enabled--verboseorNX_VERBOSE_LOGGING=trueis setThe resulting logs can be quite noisy.
Expected Behavior
When
debugis explicitly set to false, ignore logs even when--verboseis passed.Usage:
Related Issue(s)
Fixes #29320